-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports - Steph #28
base: master
Are you sure you want to change the base?
Ports - Steph #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall great job! I'm impressed with how precise and specific you get with your selectors. It makes the html cleaner because you're adding less classes or ids there. Your CSS following the flow of your HTML made it easy to follow too! Keep up the hard work!!
font-size: 25px; | ||
} | ||
|
||
a[href="#"]{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job using specific selectors
grid-column-end: 3; | ||
height: 100px; | ||
width: 100px; | ||
padding-left: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to add padding on the right? If you added about 10px you would have a little space between the text and images :)
font-weight: bold; | ||
} | ||
|
||
nav ul li:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool hover effect!
margin-right:auto; | ||
} | ||
|
||
.quote1{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The characters overlap here if the window is made smaller. What do you think would happen if you used flexbox?
.quote2 p{ | ||
margin-left: 300px; | ||
} | ||
.quote2 blockquote:before, .quote2 blockquote:after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know content could be added like this through CSS. This was very clever of you.
And thank you Kaida for pointing out that this is the CSS2 implementation of a pseudo element. CSS5 uses two colons for pseudo elements
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions