Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Steph #28

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Ports - Steph #28

wants to merge 13 commits into from

Conversation

smarchante1
Copy link

Startrly

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
How are CSS Grid & Flexbox similar Both CSS grid and Flexbox allow you to change the layout and format of html elements in your code.
Give one example where you choose Flexbox over Grid When displaying the team list I opted to use flexbox over grid.
Where did you choose to use CSS Grid and why did you make that decision I used CSS Grid throughout most of most code and I did so because I found it easier to create grids and columns and align my elements in this way.
What was the hardest part of this assignment, and why was it difficult The hardest part for me was working with margins and spacing. It was difficult because I would make one adjustment and that adjustment would seemingly break my layout.
What concept did you get the most clarity on through Startrly? How to use classes and id's and target certain elements within those classes and id's.

Copy link

@kguadron kguadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great job! I'm impressed with how precise and specific you get with your selectors. It makes the html cleaner because you're adding less classes or ids there. Your CSS following the flow of your HTML made it easy to follow too! Keep up the hard work!!

font-size: 25px;
}

a[href="#"]{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job using specific selectors

grid-column-end: 3;
height: 100px;
width: 100px;
padding-left: 10px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to add padding on the right? If you added about 10px you would have a little space between the text and images :)

font-weight: bold;
}

nav ul li:hover {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool hover effect!

margin-right:auto;
}

.quote1{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The characters overlap here if the window is made smaller. What do you think would happen if you used flexbox?

.quote2 p{
margin-left: 300px;
}
.quote2 blockquote:before, .quote2 blockquote:after {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know content could be added like this through CSS. This was very clever of you.
And thank you Kaida for pointing out that this is the CSS2 implementation of a pseudo element. CSS5 uses two colons for pseudo elements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants